Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(update-doc): build design tokens to prevent errors #8542

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Jan 3, 2024

Summary

Resolves an error in the GitHub Action that updates the component readmes, which was due to not building the design tokens before building the components.

error: https://github.com/Esri/calcite-design-system/actions/runs/7381163545/job/20079386682#step:4:178

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 3, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 3, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thanks @benelan

benelan added a commit that referenced this pull request Jan 3, 2024
**Related Issue:** #8542

## Summary

Manually update the component readmes because the CI is currently
broken, but should be fixed with the PR linked above.
@benelan benelan merged commit 624c8b4 into main Jan 3, 2024
14 checks passed
@benelan benelan deleted the benelan/fix-doc-update-action branch January 3, 2024 00:35
@github-actions github-actions bot added this to the 2024-01-17 - Jan Main Release milestone Jan 3, 2024
benelan added a commit that referenced this pull request Jan 3, 2024
…mber-infinity

* origin/main:
  ci(update-doc): build design tokens to prevent errors (#8542)
  docs: update component readmes (#8543)
  ci: consistent formatting across packages (#8534)
  refactor(list-item): Remove unnecessary code for rendering open caret (#8537)
  docs(tab-nav, table, tabs, tile-select, tree, value-list): consistent api description refs (#8535)
benelan added a commit that referenced this pull request Jan 4, 2024
…-not-internal

* origin/main:
  docs(d, f, g, and h-named components): update api description refs (#8540)
  docs(b and c components): consistent api description refs (#8536)
  ci(update-doc): build design tokens to prevent errors (#8542)
  docs: update component readmes (#8543)
  ci: consistent formatting across packages (#8534)
  refactor(list-item): Remove unnecessary code for rendering open caret (#8537)
  docs(tab-nav, table, tabs, tile-select, tree, value-list): consistent api description refs (#8535)
  chore: release next
  feat(list-item): Add dragSelected property and calciteListItemDragHandleChange event (#8524)
  chore: release next
  fix(input-date-picker): hard to reproduce numbering-system caching issue (#8518)
  feat(handle): add selected property and calciteHandleChange event. (#8484)
  docs(action-bar, action-group, action-pad, alert): consistent api decription refs (#8533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants