-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(handle): Add blurUnselectDisabled
property to disable unselecting handle on blur.
#8483
Changes from all commits
c35b0c1
085381f
447836b
4f6f728
375ee22
f3e5a01
0bf5e34
59ce46a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,13 @@ export class Handle implements LoadableComponent, T9nComponent, InteractiveCompo | |
*/ | ||
@Prop() label: string; | ||
|
||
/** | ||
* When `true`, disables unselecting the component when blurred. | ||
* | ||
* @internal | ||
*/ | ||
@Prop() blurUnselectDisabled = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a way to tie this name to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking that but I think the next step is going to be renaming |
||
|
||
/** | ||
* Use this property to override individual strings used by the component. | ||
*/ | ||
|
@@ -251,7 +258,7 @@ export class Handle implements LoadableComponent, T9nComponent, InteractiveCompo | |
}; | ||
|
||
handleBlur = (): void => { | ||
if (this.disabled) { | ||
if (this.blurUnselectDisabled || this.disabled) { | ||
return; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix any behavior in list or another consuming component? If so, is it worth adding a check there? Disregard if not the case.