Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(t-components): update usage snippets #8404

Merged
merged 7 commits into from
Dec 14, 2023
Merged

docs(t-components): update usage snippets #8404

merged 7 commits into from
Dec 14, 2023

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Dec 12, 2023

Related Issue: #6374

Summary

Audit the usage snippets for the components that start with "t".

@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Dec 12, 2023
@DitwanP
Merge branch 'main' of https://github.com/Esri/calcite-design-system …
b07dd89 
…into dit13711/6374-audit-usage-examples-for-t-components
@DitwanP DitwanP changed the title docs(t components): audited about half the t components. docs(t-components): update usage snippets Dec 12, 2023
@DitwanP DitwanP requested a review from geospatialem December 12, 2023 19:17
@DitwanP DitwanP marked this pull request as ready for review December 12, 2023 19:18
@DitwanP DitwanP requested a review from a team as a code owner December 12, 2023 19:18
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 12, 2023
geospatialem
geospatialem approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic update! 📚

Noticed the components type declaration file was also changed in this PR, is that intended? It looks like its in alignment with main, so it might be okay.

packages/calcite-components/src/components/tip-manager/usage/Basic.md Show resolved Hide resolved
packages/calcite-components/src/components/tip-manager/usage/Basic.md Outdated Show resolved Hide resolved
@DitwanP
Copy link
Contributor Author

DitwanP commented Dec 14, 2023

Fantastic update! 📚

Noticed the components type declaration file was also changed in this PR, is that intended? It looks like its in alignment with main, so it might be okay.

Yeah this was an issue that was going on with lint-staged auto formatting or something, Erik and Ben talked about it in the Core - Dev channel relatively recently. Ben mention that he had a fix for it but it should be fine to include in the PR's.

@DitwanP DitwanP merged commit 0439e2e into main Dec 14, 2023
10 checks passed
@DitwanP DitwanP deleted the dit13711/6374-audit-usage-examples-for-t-components branch December 14, 2023 19:22
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 14, 2023
@geospatialem
Copy link
Member

Noticed the components type declaration file was also changed in this PR, is that intended? It looks like its in alignment with main, so it might be okay.

Yeah this was an issue that was going on with lint-staged auto formatting or something, Erik and Ben talked about it in the Core - Dev channel relatively recently. Ben mention that he had a fix for it but it should be fine to include in the PR's.

Awesome, thanks for digging into this! 🕵🏻 It looks like the file was excluded from the files once the PR was merged. ✨ 🙌🏻 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem approved these changes

Assignees

@DitwanP DitwanP

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 December Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@DitwanP @geospatialem