Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(modal): update fullscreen context to updated widthScale prop #8313

Merged
merged 1 commit into from
Dec 1, 2023
Merged

docs(modal): update fullscreen context to updated widthScale prop #8313

merged 1 commit into from
Dec 1, 2023

Conversation

geospatialem
Copy link
Member

Related Issue: #8250

Summary

Updates the modal's fullscreen prop context to the updated widthScale prop (previously named scale).

@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 1, 2023
@geospatialem geospatialem requested a review from a team as a code owner December 1, 2023 16:04
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Dec 1, 2023
driskull
driskull approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geospatialem geospatialem merged commit adf1a16 into rc Dec 1, 2023
9 checks passed
@geospatialem geospatialem deleted the geospatialem/8250-docs-modal-fullscreen-widthScale branch December 1, 2023 17:15
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 1, 2023
benelan pushed a commit that referenced this pull request Dec 1, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
58ec5cb 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
benelan pushed a commit that referenced this pull request Dec 1, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
26aff17 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
benelan pushed a commit that referenced this pull request Dec 2, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
1d7a64c 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@geospatialem geospatialem

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 December Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@geospatialem @driskull