Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(shell-panel): remove incorrect information from heightScale prop #8302

Merged
merged 4 commits into from
Nov 30, 2023
Merged

docs(shell-panel): remove incorrect information from heightScale prop #8302

merged 4 commits into from
Nov 30, 2023

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Nov 29, 2023 •
edited
Loading

Related Issue: #8286

Summary

Updated the description of the heightScale property for Shell Panel to correctly reflect the actual behavior.

@DitwanP DitwanP changed the title Remove incorrect information from heightScale prop docs(shell-panel): remove incorrect information from heightScale prop Nov 30, 2023
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Nov 30, 2023
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 30, 2023
@DitwanP DitwanP marked this pull request as ready for review November 30, 2023 16:19
@DitwanP DitwanP requested a review from a team as a code owner November 30, 2023 16:19
@DitwanP DitwanP requested a review from geospatialem November 30, 2023 16:19
driskull
driskull approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@DitwanP DitwanP merged commit e8f6b8e into main Nov 30, 2023
14 checks passed
@DitwanP DitwanP deleted the DitwanP/8286-docs-fix-heightScale-prop-description-for-shell-panel branch November 30, 2023 19:24
@github-actions github-actions bot added this to the 2023 December Priorities milestone Nov 30, 2023
benelan added a commit that referenced this pull request Nov 30, 2023
@benelan
Merge remote-tracking branch 'origin/main' into benelan/8057-input-me…
5413643 
…ssage

* origin/main:
  chore: release next
  feat(list): support multiple selection using the shift key (#8301)
  docs(shell-panel): remove incorrect information from heightScale prop (#8302)
benelan added a commit that referenced this pull request Dec 1, 2023
@benelan
Merge remote-tracking branch 'origin/main' into benelan/8057-status-prop
0c17c5f 
* origin/main:
  chore: release next
  fix(input-time-zone): update time zone items when item-dependent props change (#8271)
  build: update browserslist db (#8260)
  chore: release next
  feat(list): support multiple selection using the shift key (#8301)
  docs(shell-panel): remove incorrect information from heightScale prop (#8302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@DitwanP DitwanP

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 December Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@DitwanP @driskull