Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(link, loader, modal, notice, panel, select): update usage examples #8267

Merged
merged 6 commits into from
Nov 28, 2023
Merged

docs(link, loader, modal, notice, panel, select): update usage examples #8267

merged 6 commits into from
Nov 28, 2023

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Nov 27, 2023

Related Issue: #6374

Summary

Updates component usage examples for components listed in title

@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Nov 27, 2023
@DitwanP DitwanP marked this pull request as ready for review November 28, 2023 15:31
@DitwanP DitwanP requested a review from a team as a code owner November 28, 2023 15:31
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 28, 2023
geospatialem
geospatialem approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome updates! ✨ 🧹✨

A few considerations for follow-up and some nitpicks, WDYT?

packages/calcite-components/src/components/select/usage/Side-by-side.md Outdated Show resolved Hide resolved
packages/calcite-components/src/components/panel/usage/With-fab.md Outdated Show resolved Hide resolved
packages/calcite-components/src/components/panel/usage/With-fab.md Outdated Show resolved Hide resolved
packages/calcite-components/src/components/modal/usage/Basic.md Outdated Show resolved Hide resolved
packages/calcite-components/src/components/link/usage/Basic.md Outdated Show resolved Hide resolved
@DitwanP
Copy link
Contributor Author

DitwanP commented Nov 28, 2023

Awesome updates! ✨ 🧹✨

A few considerations for follow-up and some nitpicks, WDYT?

I think they are better now if you want to take a second look before I move forward.

@DitwanP DitwanP merged commit 383bdf8 into main Nov 28, 2023
10 checks passed
@DitwanP DitwanP deleted the DitwanP/6374-docs-update-components-usage-for-6-components branch November 28, 2023 18:17
@github-actions github-actions bot added this to the 2023 December Priorities milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@DitwanP DitwanP

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 December Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@DitwanP @geospatialem