Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align expected node engine with volta #7998

Merged
merged 5 commits into from
Oct 24, 2023
Merged

chore: align expected node engine with volta #7998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d0002f
chore: align expected node engine with volta
alisonailea Oct 12, 2023
707154c
chore: add required node engine to published calicte-components
alisonailea Oct 24, 2023
0944233
fix: remove node engines as unnecessary
alisonailea Oct 24, 2023
a6099b3
docs: specify using the volta version for development
alisonailea Oct 24, 2023
19ae91c
chore: add volta reference back to calcite-components
alisonailea Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Our code base is written in TypeScript and must adhere to specific conventions a

## Getting a development environment set up

An installation of Node is required for development. If you don't have Node installed, we recommend [Volta](https://docs.volta.sh/guide/getting-started), which will automatically use the Node/NPM versions pinned at the bottom of [`package.json`](./package.json). If you prefer a different Node version manager, make sure to use the major versions of Node/NPM specified in [`package.json`](./package.json).
An installation of Node is required for development. If you don't have Node installed, we recommend [Volta](https://docs.volta.sh/guide/getting-started), which will automatically use the Node/NPM versions pinned at the bottom of [`package.json`](./package.json). If you prefer a different Node version manager, make sure to use the major versions of Node/NPM specified under the "volta" key in [`package.json`](./package.json).

We also recommend installing the following extensions in your editor of choice: TypeScript, TailwindCSS, ESLint, Stylelint, and Prettier. If you use VS Code, you will see a pop up in the bottom right corner prompting you to install or view the workspaces's recommended extensions. Here are instructions for manually installing the extensions in a variety of editors:

Expand Down
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@
"workbox-build": "7.0.0"
},
"license": "SEE LICENSE.md",
"engines": {
"node": ">=16.0.0"
},
"packageManager": "npm@10.1.0",
"volta": {
"node": "18.18.0",
Expand Down