Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): Add support for dragging items. #7109
feat(list): Add support for dragging items. #7109
Changes from 48 commits
59f1968
ceea051
0478bb0
84cd376
49ce1f8
ae85ebc
5bcd803
2eae6be
befbfea
bf8ecad
84502ef
88a9258
9a7b80d
5ef19b2
de11b60
ccc748e
8ab64fe
0cacf88
a2acfdb
ccf0a9a
628c09f
a553935
9b6dd24
f010af2
24e20e9
1c922ba
d0eae6a
19e9eff
d06d16f
980a144
9b6c5eb
e4943b0
69c3138
bbf9a68
d20bea8
99e5e12
f97ceea
3580920
f1f94c7
202b9e7
ca77444
83fb4c0
98acf7d
b7eb538
4b4329a
e174a94
162cd5e
f820923
f826ce0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this arrow function need to be called each render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its only called once when the ref is established
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just seen patterns where we declare a private method on the class for assigning the ref so that the function doesn't have to get recalled on every render, so that stood out to me.