Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): bumping scale of chevron icon to M when host is scale l #6335

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jan 25, 2023

Related Issue: #5698

Summary

Bumping the scale of the chevron to M when host is scale="l" for a visual distinction between larger and smaller components without affecting the height of the component when icon(s) are added or removed. Added a _testOnly snapshot.

@Elijbet Elijbet requested a review from a team as a code owner January 25, 2023 00:06
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 25, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 25, 2023
@Elijbet Elijbet merged commit fa91ec1 into master Jan 25, 2023
@Elijbet Elijbet deleted the elijbet/5698-select-scale-L-renders-icon-scale-M branch January 25, 2023 02:28
@github-actions github-actions bot added this to the 2023 January Priorities milestone Jan 25, 2023
benelan added a commit that referenced this pull request Jan 26, 2023
…nter

* origin/master:
  1.0.3
  docs: update component READMEs (#6337)
  docs: update license year (#6339)
  fix(pagination): bumping scale of chevron icon to M when host is scale L (#6338)
  ci: prepare release scripts for v1 (#6336)
  ci: add npm script to remove js files compiled by tsc (#6333)
  1.0.0-next.736
  fix(select): bumping scale of chevron icon to M when host is scale l (#6335)
  1.0.0-next.735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants