Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(floating-ui): drop unnecessary code for patched offsetParent #6313

Closed
wants to merge 6 commits into from
Closed

refactor(floating-ui): drop unnecessary code for patched offsetParent #6313

wants to merge 6 commits into from

Conversation

jcfranco
Copy link
Member

Related Issue: #5542

Summary

This shaves some bits by dropping duplicate code needed to provide our own getOffsetParent implementation before floating-ui/floating-ui#1962 landed.

Note: Leaving this as a draft until 1.0 ships.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 20, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 28, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. labels Feb 10, 2023
@jcfranco jcfranco changed the title refactor(floating-ui): drop workaround floating-ui utils refactor(floating-ui): drop unnecessary code for patched offsetParent Feb 10, 2023
@jcfranco jcfranco marked this pull request as ready for review February 10, 2023 18:39
@jcfranco jcfranco requested a review from a team as a code owner February 10, 2023 18:39
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 14, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 22, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 23, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 24, 2023
@jcfranco
Copy link
Member Author

Superseded by #6520.

@jcfranco jcfranco closed this Feb 27, 2023
@jcfranco jcfranco deleted the jcfranco/drop-obsolete-inlined-floating-ui-utils branch February 27, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfranco jcfranco

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfranco