fix(combobox-item): bumping the scale of icon to M when parent combobox is scale L #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
👍
In the future these 3 changes can be in one PR since they do the same thing, just for different components. It would save us chromatic snapshots too. The PR title could be something like:
fix(combobox-item, accordion-item, dropdown-item): increase child icon scale to M when component is L
alisonailea
approved these changes
Jan 10, 2023
benelan
added a commit
that referenced
this pull request
Jan 11, 2023
* master: 1.0.0-next.719 fix(combobox-item): bumping the scale of icon to M when parent combobox is scale L (#6253) 1.0.0-next.718 fix(button): neutral and outline button now has correct border color (#6269) style: lint and use tsserver LSP to organize imports (#6260) build(deps): Bump axe-core from 4.6.1 to 4.6.2 (#6264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5698
Bumping the scale of the icon to M when the parent
combobox-itemis scale="l" for a visual distinction between larger and smaller components without affecting the height of thecombobox-itemwhen icon(s) are added or removed. Added a _testOnly snapshot.