Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker)!: remove deprecated intl* & accessible label properties #6041

Merged
merged 6 commits into from
Dec 15, 2022
Merged

refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker)!: remove deprecated intl* & accessible label properties #6041

merged 6 commits into from
Dec 15, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 14, 2022 •
edited
Loading

BREAKING CHANGE: Removed deprecated intl* & accessible label properties.

  • card:

    • Removed the property intlLoading , use messsageOverrides.loading instead.
    • Removed the property intlSelect use messageOverrides.select instead.
    • Removed the property intlDeselect use messageOverrides.deselect instead.

  • chip:

    • Removed the property dismissLabel , use messsageOverrides.dismissLabel instead.

  • color-picker:

    • Removed the property intlB , use messsageOverrides.b instead.
    • Removed the property intlBlue , use messsageOverrides.blue instead.
    • Removed the property intlDeleteColor , use messsageOverrides.deleteColor instead.
    • Removed the property intlG , use messsageOverrides.g instead.
    • Removed the property intlGreen , use messsageOverrides.green instead.
    • Removed the property intlH , use messsageOverrides.h instead.
    • Removed the property intlHsv , use messsageOverrides.hsv instead.
    • Removed the property intlHex , use messsageOverrides.hex instead.
    • Removed the property intlHue , use messsageOverrides.hue instead.
    • Removed the property intlNoColor , use messsageOverrides.noColor instead.
    • Removed the property intlR , use messsageOverrides.r instead.
    • Removed the property intlRed , use messsageOverrides.red instead.
    • Removed the property intlRgb , use messsageOverrides.rgb instead.
    • Removed the property intlS , use messsageOverrides.s instead.
    • Removed the property intlSaturation , use messsageOverrides.saturation instead.
    • Removed the property intlSaveColor , use messsageOverrides.saveColor instead.
    • Removed the property intlSaved , use messsageOverrides.saved instead.
    • Removed the property intlV , use messsageOverrides.v instead.
    • Removed the property intlValue , use messsageOverrides.value instead.

  • combobox:

    • Removed the property intlRemoveTag , use messsageOverrides.removeTag instead.

  • date-picker

    • Removed the property intlNextMonth, use messageOverrides.nextMonth instead.
    • Removed the property intlPrevMonth, use messageOverrides.prevMonth instead.
    • Removed the property intlYear, use messageOverrides.year instead.

  • flow-item:

    • Removed the property intlBack , use messsageOverrides.back instead.
    • Removed the property intlClose, use messageOverrides.close instead.
    • Removed the property intlOptions , use messsageOverrides.options instead.

  • filter:

    • Removed the property intlClear, use messsageOverrides.clear instead.
    • Removed the property intlLabel, use messageOverrides.label instead.

  • input-date-picker:

    • Removed the property intlNextMonth, use messageOverrides.nextMonth instead.
    • Removed the property intlPrevMonth, use messageOverrides.prevMonth instead.
    • Removed the property intlYear, use messageOverrides.year instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 14, 2022
@anveshmekala anveshmekala changed the title refactor(chip,card,combobox,flow,flow-item,filter): remove deprecated intl properties refactor(chip,card,combobox,date-picker,flow,flow-item,filter): remove deprecated intl* properties Dec 14, 2022
@anveshmekala anveshmekala changed the title refactor(chip,card,combobox,date-picker,flow,flow-item,filter): remove deprecated intl* properties refactor(chip,card,combobox,date-picker,flow,flow-item,filter): remove deprecated intl* & accessible label properties Dec 14, 2022
@anveshmekala anveshmekala changed the title refactor(chip,card,combobox,date-picker,flow,flow-item,filter): remove deprecated intl* & accessible label properties refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated intl* & accessible label properties Dec 15, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 15, 2022 00:18
@anveshmekala anveshmekala requested a review from a team as a code owner December 15, 2022 00:18
@anveshmekala anveshmekala added breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
driskull
driskull approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you format the body text of the PR to use a list with indented items.

  • Card
    • Removed the property intlLoading , use messsageOverrides.loading instead.

@anveshmekala anveshmekala merged commit 4bf8b6d into master Dec 15, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5946-remove-intl-deprecations-CtoF branch December 15, 2022 00:35
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
benelan added a commit that referenced this pull request Dec 15, 2022
@benelan
Merge branch 'master' into benelan/delegatesFocus-no-mock-disabled
9030f13 
* master: (21 commits)
  1.0.0-next.685
  refactor(modal)!: Renamed property and updated values (#6054)
  1.0.0-next.684
  refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046)
  refactor(tree)!: remove `event.detail` payload from events (#6051)
  docs(changelog): fix breaking change indent levels (#6057)
  1.0.0-next.683
  refactor(pagination)!: remove `event.detail` payload from events (#6047)
  refactor(dropdown)!: remove `event.detail` payload from events (#6044)
  refactor(rating)!: remove `event.detail` payload from events (#6045)
  refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049)
  1.0.0-next.682
  refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053)
  docs: update component READMEs (#6052)
  1.0.0-next.681
  refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041)
  refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982)
  1.0.0-next.680
  refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036)
  refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040)
  ...
@anveshmekala anveshmekala changed the title refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated intl* & accessible label properties refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker)!: remove deprecated intl* & accessible label properties Dec 16, 2022
@jcfranco jcfranco mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull