Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #57: Set up Prettier #60

Merged
merged 6 commits into from
Jun 14, 2019
Merged

Issue #57: Set up Prettier #60

merged 6 commits into from
Jun 14, 2019

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jun 14, 2019

Sets up Prettier along with some NPM scripts to prettify™ all the things.

Once the config is reviewed and agreed upon, I'll format the source and include it in this PR.

#57

@jcfranco jcfranco added this to the 1.0.0 milestone Jun 14, 2019
@jcfranco jcfranco self-assigned this Jun 14, 2019
@paulcpederson
Copy link
Member

My only comment is jsxBracketSameLine: false Gives you a lot of dangling > characters, but fundamentally it really doesn't matter. Thanks for setting this up 👍

Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah all looks good, agree with @paulcpederson on bracket clutter, but, just preference. Thanks for adding. We could also put together a vs code settings gist with prettier-on-save, etc.

@jcfranco
Copy link
Member Author

Moving forward w/ current config. A reason for jsxBracketSameLine is that it doesn't require messing with the closing angle bracket when making changes around the last attribute. We can always tweak it if needed.

@jcfranco jcfranco merged commit bcc1eea into master Jun 14, 2019
@jcfranco jcfranco deleted the jcfranco/#57-set-up-prettier branch June 14, 2019 23:24
@paulcpederson
Copy link
Member

✨ ✨ ✨ ✨ ✨ ✨

@macandcheese
Copy link
Contributor

macandcheese commented Jun 15, 2019

After looking at results... maybe a little longer printWidth? Seems to break a lot of our top level imports to multiline which... is kind of noisy.

Obviously it just becomes a guessing game with an arbitrary length at some point... Ha

@jcfranco
Copy link
Member Author

@macandcheese Could you create an issue to discuss potential tweaks? I'd like to get consensus on changes before re-purtyfying™.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants