Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-message,loader): reverts breaking change #5656

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix(input-message,loader): reverts breaking change #5656

merged 2 commits into from
Oct 27, 2022

Conversation

geospatialem
Copy link
Member

@geospatialem geospatialem commented Oct 27, 2022 •
edited
Loading

Related Issue: #3821

Summary

Reverts breaking change for loader and input-message's active props from #5537.

To be incorporated in the upcoming CC release, beta.97.

@geospatialem geospatialem requested a review from a team as a code owner October 27, 2022 17:16
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 27, 2022
driskull
driskull reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @geospatialem Thanks for getting this together!

Can we update the changelog here too to remove the entry for the feature?

@geospatialem
Copy link
Member Author

Can we update the changelog here too to remove the entry for the feature?

@driskull Good call! Removed from the entry.

driskull
driskull approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geospatialem geospatialem added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 27, 2022
@geospatialem geospatialem merged commit 80376a8 into master Oct 27, 2022
@geospatialem geospatialem deleted the geospatialem/3821-revert-breaking-change branch October 27, 2022 19:30
@geospatialem geospatialem mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@geospatialem geospatialem

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/10/24 - 2022/11/04
Development

Successfully merging this pull request may close these issues.
2 participants
@geospatialem @driskull