-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix jarring positioning when a closed component is first opened #5484
Merged
benelan
merged 20 commits into
master
from
jcfranco/5399-fix-initial-jarring-floating-ui-positioning
Oct 24, 2022
Merged
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
adb0d93
fix: fix jarring positioning when a closed component is first opened
jcfranco 048e245
uncomment actual fix and switch story to be stepped
jcfranco 23cedd0
tweak story to capture initial positioning
jcfranco d7369df
fix typo
jcfranco b376ae6
add missing setAttr argument
jcfranco 8612077
add delay before screenshot test setup
jcfranco d077a9a
Merge branch 'master' into jcfranco/5399-fix-initial-jarring-floating…
jcfranco b11cf60
revisit approach to preserve debounced internal repositioning calls a…
jcfranco 55ccb88
drop unnecessary story
jcfranco ce4a5ce
tidy up
jcfranco 92ba61c
fix hydrate build
jcfranco 31ea11a
restore leading option
jcfranco dead552
update test
jcfranco 1759253
tweak positioning
jcfranco 4076360
update tests
jcfranco fb49e36
revert index.html updates
jcfranco 477bd69
use transitions to reset positioning
jcfranco 9e59210
merge master
jcfranco 72876cf
fix test.
driskull c2efc24
Merge branch 'master' into jcfranco/5399-fix-initial-jarring-floating…
driskull File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍