Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rating): add built-in translations #5437

Merged
merged 35 commits into from
Oct 19, 2022
Merged

feat(rating): add built-in translations #5437

merged 35 commits into from
Oct 19, 2022

Conversation

jcfranco
Copy link
Member

Related Issue: #4961

Summary

Wires up translations to the rating component.

@jcfranco jcfranco requested a review from a team as a code owner October 11, 2022 02:24
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Oct 11, 2022
@jcfranco jcfranco requested a review from anveshmekala October 11, 2022 02:26
jcfranco and others added 6 commits October 10, 2022 19:42
@jcfranco
set asset dir
7d0c710
@jcfranco
add initial message load
86cb8b5
@jcfranco
add effectiveLocale watcher
e4a8b5b
@jcfranco
fix outdated reference
949d55e
@jcfranco
update lang switch helper to account for strings used in rendering
28d564c
@benelan
feat(time-picker, input-time-picker): add numberingSystem property (#…
7eaf051 
…5301)

* feat(time-picker, input-time-picker): add numberingSystem property for localization

* wip: need to correctly apply numberingSystem on InputInput

* use NumberStringFormat to delocalize time

* cleanup

* delocalize time on blur

* test(input-time-picker): fix e2e failures and add numberingSystem story

* use formatter's format method instead of localize for performance

* cleanup

* fix(input-time-picker): don't pass through lang and numberingSystem to calcite-input

* fix test

* use NumberStringFormat's  setter instead of setOptions

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
@anveshmekala anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations October 13, 2022 22:39
jcfranco and others added 9 commits October 13, 2022 16:51
@jcfranco
refactor(block): move hardcoded classes to CSS object (#5474)
d81065d
@jcfranco
fix(input, input-number, input-text): fix input icons not displaying …
3d6ba64 
…properly in Firefox (#5475)

#5417
@benelan
ci(next): clean docs build before deployment (#5476)
a647345 
* ci(prepReleaseCommit): skip git sanity checks for next releases

* ci(next): clean docs build before deployment

* Revert "ci(prepReleaseCommit): skip git sanity checks for next releases"

This reverts commit 7cc2d8b.

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
@jcfranco
refactor(input-number, input-text): drop resize-icon selectors (#5477)
3898927
@jcfranco
fix(block): improve content layout (#5473)
2cc0a5f 
#5422
@calcite-admin @jcfranco
docs: update component READMEs (#5479)
66bf66e 
Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
@geospatialem
docs: add backticks to props and values for consistency (#5485)
048527b 
* docs: add backticks to props and values for consistency

* update prop ref

* review edits
@anveshmekala
fix(date-picker): no longer hides year for zh-CN locale (#5344)
d10593e 
* fix(date-picker): no longer hides year for zn-CH locale

* add screener story

* fix locale typo

* fix  suffix placement
@jcfranco
docs(changelog): add missing breaking changes (#5469)
5e3d7ab
anveshmekala
anveshmekala reviewed Oct 17, 2022
View reviewed changes
src/tests/commonTests.ts

component.setAttribute("lang", "es");
await page.waitForChanges();
await page.waitForTimeout(3000);
const esMessages = await getCurrentMessages();

expect(esMessages).toEqual({});
expect(esMessages).toHaveProperty(fakeBundleIdentifier);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can assert esMessages toEqual enMessage without the need of adding fakeBundleIdentifier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we did so, this would no longer catch problems with locale bundle switching as the en one wouldn't change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense.

anveshmekala
anveshmekala approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

benelan and others added 7 commits October 17, 2022 14:24
@benelan
feat(stepper, stepper-item): add numberingSystem property (#5467)
9ca3117 
* feat(stepper, stepper-item): add numberingSystem property

* use setter for NumberStringFormat's options instead of setOptions

* change formatter options in effectiveLocale watcher

* cleanup

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
@jcfranco
fix(flow-item): fix scrollContentTo (#5487)
246e470 
#5414
@benelan
ci(next): fix next releases take 3 (#5497)
f579f06 
* ci(next): fix next releases take 3

* cleanup

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
@jcfranco
fix(flow-item, panel): fix layout issue that would cause double scrol…
96dcb78 
…lbars (#5486)

#5428
@benelan
1.0.0-next.598
5419b52
@calcite-admin @jcfranco
docs: update component READMEs (#5501)
072a09e 
Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
@dependabot
build(deps): bump eslint-plugin-jest from 27.1.1 to 27.1.2 (#5507)
826ab24 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.1.1 to 27.1.2.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.1.1...v27.1.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 12 commits October 18, 2022 11:03
@dependabot
build(deps): bump shell-quote from 1.7.3 to 1.7.4 (#5503)
0a44d80 
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/ljharb/shell-quote/releases)
- [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md)
- [Commits](ljharb/shell-quote@1.7.3...v1.7.4)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @typescript-eslint/eslint-plugin from 5.38.1 to 5.4…
f521c1a 
…0.1 (#5506)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.38.1 to 5.40.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @typescript-eslint/parser from 5.38.1 to 5.40.1 (#5504
e1d06f9 
)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.38.1 to 5.40.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump eslint-plugin-jsdoc from 39.3.6 to 39.3.13 (#5505)
06ab974 
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 39.3.6 to 39.3.13.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Commits](gajus/eslint-plugin-jsdoc@v39.3.6...v39.3.13)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Elijbet
fix(tree, tree-item): works when tree is the topmost element in a sha…
8ac3785 
…dow root where it has no parent (#5472)

#5333
@benelan
ci: fix next releases take 4 (#5500)
553e419 
* ci: fix next releases take 4

* separate error messages

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
@github-actions
1.0.0-next.599
cb4835b
@driskull
fix(flow-item): Render back button first. (#5511)
35b10e7
@github-actions
1.0.0-next.600
c63b8d8
@Elijbet
fix(tab): applies section styles onto the enclosing parent (#5516)
f3e06a4 
* WIP: temorary demo swap with the issue case

* fix(tab): applies section styles onto the enclosing parent

* revert to original demo

* cleanup

* TabChilrenWithPercentageHeights story

* cleanup

* swap parent selector for [role=tabpanel]

* Introduce a new class selector
@github-actions
1.0.0-next.601
b12b123
@jcfranco
merge master
a6f76c0
@anveshmekala anveshmekala merged commit 8c686ec into anveshmekala/4961-add-built-in-pseudo-translations Oct 19, 2022
@anveshmekala anveshmekala deleted the jcfranco/4961-add-built-in-localization-for-rating branch October 19, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anveshmekala anveshmekala anveshmekala approved these changes

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcfranco @anveshmekala @benelan @calcite-admin @geospatialem @Elijbet @driskull