Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action,action-bar, action-group,action-pad): add built in translation support #5423

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Oct 7, 2022

Related Issue: #4961

Summary

This PR will add built-in support for cacite-action , calcite-action-bar, calcite-action-group & calcite-action-pad.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Oct 15, 2022
@anveshmekala anveshmekala removed the Stale Issues or pull requests that have not had recent activity. label Oct 18, 2022
@anveshmekala anveshmekala changed the base branch from jcfranco/4961-add-built-in-localization-to-components to master October 18, 2022 21:27
@anveshmekala anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations October 20, 2022 18:39
…o anveshmekala/4961-action-add-built-in-translation-support
…o anveshmekala/4961-action-add-built-in-translation-support
@anveshmekala anveshmekala marked this pull request as ready for review October 20, 2022 18:50
@anveshmekala anveshmekala requested a review from a team as a code owner October 20, 2022 18:50
@anveshmekala anveshmekala requested a review from jcfranco October 20, 2022 18:51
@anveshmekala anveshmekala changed the base branch from anveshmekala/4961-add-built-in-pseudo-translations to master October 20, 2022 18:51
@anveshmekala anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations October 20, 2022 19:13
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a question regarding the use of Build.isBrowser, this LGTM! 🎉

src/components/action/action.tsx Outdated Show resolved Hide resolved
@anveshmekala anveshmekala changed the base branch from anveshmekala/4961-add-built-in-pseudo-translations to master October 26, 2022 20:30
@anveshmekala anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations October 26, 2022 20:34
@anveshmekala anveshmekala merged commit 964e741 into anveshmekala/4961-add-built-in-pseudo-translations Oct 26, 2022
@anveshmekala anveshmekala deleted the anveshmekala/4961-action-add-built-in-translation-support branch October 26, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants