-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deprecate conditionalSlot utility and getSlotted method #5380
Merged
driskull
merged 12 commits into
master
from
dris0000/deprecate-conditional-slot-component
Nov 16, 2022
Merged
refactor: Deprecate conditionalSlot utility and getSlotted method #5380
driskull
merged 12 commits into
master
from
dris0000/deprecate-conditional-slot-component
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
Issues tied to code that needs to be significantly reworked.
label
Sep 23, 2022
driskull
changed the title
refactor: Deprecate conditionalSlot utility.
refactor: Deprecate conditionalSlot utility
Sep 26, 2022
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Oct 4, 2022
@jcfranco I can haz install? |
driskull
changed the title
refactor: Deprecate conditionalSlot utility
refactor: Deprecate conditionalSlot utility and getSlotted method
Nov 15, 2022
jcfranco
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Good to merge once the new utils have tests.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #
Summary
refactor: Deprecate conditionalSlot utility.
conditionalSlot
utility class in favor ofhasAssignedElement
dom utility.onSlotchange
works perfectly.conditionalSlot
utility class will not work ifComponentA
slots into a slot inComponentB
.getSlotted
utility function in favor ofonSlotChange
.Example: Component has slotted elements
Example: Getting slotted elements