Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button)!: Change type property to be "button" by default #4335

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix(button)!: Change type property to be "button" by default #4335

merged 1 commit into from
Apr 6, 2022

Conversation

driskull
Copy link
Member

Related Issue: #4117

Summary

fix(button)!: Change type property to be "button" by default. (#4117)

@github-actions github-actions bot added this to the Sprint 03/28 - 04/08 milestone Mar 30, 2022
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Mar 30, 2022
@driskull driskull marked this pull request as ready for review March 30, 2022 20:48
@driskull driskull requested a review from a team as a code owner March 30, 2022 20:48
jcfranco
jcfranco approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Can you hold off on installing until release time wraps up?

Also, right before merging, can you add a BREAKING CHANGES: note for users in the commit message body about this (the issue description has one you could repurpose).

@driskull driskull merged commit 0ff143c into master Apr 6, 2022
@driskull driskull deleted the dris0000/button-type-change branch April 6, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 03/28 - 04/08
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco