-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rerender components with conditional slots when slotting elements after initialization #3871
Merged
jcfranco
merged 8 commits into
master
from
jcfranco/3686-rerender-conditionally-slotted-components-after-slotting
Jan 13, 2022
Merged
fix: rerender components with conditional slots when slotting elements after initialization #3871
jcfranco
merged 8 commits into
master
from
jcfranco/3686-rerender-conditionally-slotted-components-after-slotting
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s after initialization
driskull
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
…fault slot to force rerendering when other slotted elements are added
asangma
reviewed
Jan 13, 2022
driskull
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Existing test failure is unrelated: Summary of all failing tests
FAIL src/components/calcite-dropdown/calcite-dropdown.e2e.ts (69.154 s)
● calcite-dropdown › opens the dropdown with click, enter, or space › opens when dropdown-trigger is an action
expected event "calciteDropdownOpen" to have been called 1 times, but was called 2 times
828 | await page.waitForChanges();
829 | expect(await dropdownWrapper.isVisible()).toBe(true);
> 830 | expect(calciteDropdownOpen).toHaveReceivedEventTimes(1);
| ^
831 | });
832 | });
833 |
at Object.<anonymous> (src/components/calcite-dropdown/calcite-dropdown.e2e.ts:830:35) cc @Elijbet All other checks are ✅. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3686
Summary
This PR updates components that were already using
getSlotted
for conditionally rendering their named slots to use the interface and utils from theconditionalSlot.ts
util.Notable changes
slots
test helper to help test conditional renderingcalcite-panel
's footer slot rendering to render both slots†† Reasoning for 3: