feat(tile-select): add calciteTileSelectChange event #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in in tile-select
…ndlers to match conventions in checkbox and radio-button
…e events are also suppressed
eriklharper
commented
Oct 9, 2021
jcfranco
approved these changes
Oct 11, 2021
|
@eriklharper Should this use a |
eriklharper
added a commit
that referenced
this pull request
Nov 16, 2021
…steners back to tile-select after introducing them in #3187
eriklharper
added a commit
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3175
Summary
This PR adds a new
calciteTileSelectChangeevent tocalcite-tile-selectthat emits on every toggle for checkboxes and only when a radio is checked, which matches the HTML spec.This PR also adds an internal
calciteCheckboxBlurevent tocalcite-checkboxand an internalcalciteRadioButtonBlurevent tocalcite-radio-buttonso that the previously named "focusedChanged" events can be updated to match the native nomenclature for focus and blur events in the HTML spec. This PR also simplifies the names of event handlers and makes them more meaningful.