chore(CONTRIBUTORS.md): add note for new contributors #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
reviewed
Jul 19, 2021
CONTRIBUTING.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| Esri welcomes contributions from anyone and everyone. Please see our [guidelines for contributing](https://github.com/esri/contributing). | |||
|
|
|||
| (Note: As a new contributor, please email [Julio Ochoa](JOchoa@esri.com) to join the [Calcite Components GitHub team](https://github.com/orgs/Esri/teams/calcite-components/members). Then, clone the repo via SSH on your machine.) | |||
There was a problem hiding this comment.
Nitpick:
Note: New contributors should contact ...*no parens + minor tweak
A couple of questions:
- Should this also have a short line about this being needed for the testing setup to work properly?
- How do we communicate this for anyone contributing code that would not get access to the GitHub team?
There was a problem hiding this comment.
For the long term stability of the repository, we need the PR to come from the repo itself for screener, etc. Would be good to mention this so that folks know why we need to add them, as it is adding a certain barrier to contributing.
I would add Franco in there too, as a backup.
jcfranco
approved these changes
Jul 19, 2021
CONTRIBUTING.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| Esri welcomes contributions from anyone and everyone. Please see our [guidelines for contributing](https://github.com/esri/contributing). | |||
|
|
|||
| (Note: As a new contributor, please email [Julio Ochoa](JOchoa@esri.com) to join the [Calcite Components GitHub team](https://github.com/orgs/Esri/teams/calcite-components/members). Then, clone the repo via SSH on your machine.) | |||
| Note: New contributors should first contact [Julio Ochoa](JOchoa@esri.com) or [Juan Carlos Franco](JFranco@esri.com) to join the [Calcite Components GitHub team](https://github.com/orgs/Esri/teams/calcite-components/members). Then, clone the repo via SSH key on your machine. (This Git workflow is required in order to work with our Screener test integration.) | |||
There was a problem hiding this comment.
Nitpick: ... on your machine (this Git workflow is required in order to work with our Screener test integration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
Summary
Adds a new contributors note to CONTRIBUTORS.md per Teams conversation.