fix(tree): fix item selection when multi + input-enabled #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcfranco I have never understood the other selection modes or what their purpose is. Checked locally, though, and ancestors mode looks great 👍🏻 |
paulcpederson
approved these changes
Jul 16, 2021
😭 I thought you would have all the secrets! Thanks for testing! @patrickarlt Checked the blame view and saw you introduced the prop. Could you share some info on the different selection modes? It would greatly help with doc and setting up tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2437
Summary
This fixes an issue where clicking a tree-item's checkbox would not toggle the selection when a tree is in multi selection mode with input-enabled.
@paulcpederson Can you help test this one? I'm not clear if other selection modes + input-enabled need to work differently. The ancestor selection-mode + input-enabled from the demo page appear to work fine. I added an E2E test to start keeping track of this.