-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove 'theme' props from components #2194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
changed the title
DRAFT: remove theme props from components and tests
refactor!: Remove 'theme' props from components
May 21, 2021
driskull
added
the
1 - assigned
Issues that are assigned to a sprint and a team member.
label
May 21, 2021
nice! tons of work, thanks @driskull . I don't think we should be using |
For now, closest will look for either the class or attribute. Once we remove all uses of the attribute we can update the utility to remove that part. |
I think you may be able to remove the theme name vars altogether? LGTM, though |
paulcpederson
approved these changes
May 21, 2021
This was referenced Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2189
Summary
This PR is the first step of removing the use of the theme attribute selector.
The next steps would be to
Please review