Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-message): Remove undocumented properties from the Host element. #2059 #2101

Closed
wants to merge 1 commit into from
Closed

fix(input-message): Remove undocumented properties from the Host element. #2059 #2101

wants to merge 1 commit into from

Conversation

driskull
Copy link
Member

@driskull driskull commented May 5, 2021

Related Issue: #2059

Summary

fix(input-message): Remove undocumented properties from the Host element. #2059

@driskull driskull requested a review from a team as a code owner May 5, 2021 00:02
@driskull driskull self-assigned this May 5, 2021
caripizza
caripizza reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@caripizza caripizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove this theme attribute in #1737 instead? That way we won't need this todo comment and we won't break the input-message's dark theme styles before the var is moved to global.scss.

@driskull
Copy link
Member Author

driskull commented May 5, 2021

Yes, i'll assign this one to you then.

@driskull driskull closed this May 5, 2021
@driskull driskull deleted the dris0000/2059/input-message branch May 5, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caripizza caripizza caripizza left review comments

Assignees

@driskull driskull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @caripizza