fix(rating)!: display-value => show-chip, also works now #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caripizza
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Nice! Only question I have is about the displayValue prop name - this new behavior makes me instead think of a name like displayStats (or showChip like Adam had mentioned in Teams), since it applies to either count or average props on the component and not the value prop. 🤔
|
Yeah, I was going to call it |
Perfect, can you rename to |
|
@caripizza updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need the ability to hide the value of the count/average numbers. I went to add a prop for this and realized it was already there, we just weren't using it 🤦🏻 .
This updates the ratings component to pay attention to the existing
display-valueprop and adds tests, docs, jsdoc for it as well.