-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stencil): replacing stencil references #11372
base: dev
Are you sure you want to change the base?
Conversation
…nto dit13711/10889-remove-references-to-stencil
@jcfranco or @benelan Please let me know if the places where I replaced Stencil with Lit or Vitest, etc is correct. Also there's locations where I put "TODO" comments, These areas are a bit more technical and I'm not sure how many of them are still relevant and of the ones that are, what are we using now? If you guys could give some insight on those I can get them changed or removed where needed. Also also, if you guys know of anywhere else that is missing in this pass of changes please LMK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates are looking great, @DitwanP!
packages/eslint-plugin-calcite-components/docs/strict-boolean-attributes.md
Outdated
Show resolved
Hide resolved
@@ -303,6 +303,8 @@ my-component/ | |||
... | |||
``` | |||
|
|||
<!-- TODO: Get suggestions for what this should be replaced with --> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any info related to building a component with Lumina should be removed. We could add a link to the internal doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this referring to specifically? Should this whole "assets" section be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.
…nto dit13711/10889-remove-references-to-stencil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Franco covered most of it but I added some additional comments.
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
…nto dit13711/10889-remove-references-to-stencil
…nto dit13711/10889-remove-references-to-stencil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! 🚀
@@ -303,6 +303,8 @@ my-component/ | |||
... | |||
``` | |||
|
|||
<!-- TODO: Get suggestions for what this should be replaced with --> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.
Related Issue: #10889
Summary
Removing stale references to Stencil across the repo and replacing where necessary with info on Lit and other tools.