Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stencil): replacing stencil references #11372

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Jan 23, 2025

Related Issue: #10889

Summary

Removing stale references to Stencil across the repo and replacing where necessary with info on Lit and other tools.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 23, 2025
@calcite-admin calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 23, 2025
@DitwanP
Copy link
Contributor Author

DitwanP commented Jan 23, 2025

@jcfranco or @benelan Please let me know if the places where I replaced Stencil with Lit or Vitest, etc is correct.

Also there's locations where I put "TODO" comments, These areas are a bit more technical and I'm not sure how many of them are still relevant and of the ones that are, what are we using now?

If you guys could give some insight on those I can get them changed or removed where needed.

Also also, if you guys know of anywhere else that is missing in this pass of changes please LMK.

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are looking great, @DitwanP!

packages/calcite-components-react/README.md Outdated Show resolved Hide resolved
packages/calcite-components-react/README.md Outdated Show resolved Hide resolved
packages/calcite-components-react/README.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Documentation.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Documentation.md Outdated Show resolved Hide resolved
packages/eslint-plugin-calcite-components/README.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Styling.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Testing.md Outdated Show resolved Hide resolved
@@ -303,6 +303,8 @@ my-component/
...
```

<!-- TODO: Get suggestions for what this should be replaced with -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any info related to building a component with Lumina should be removed. We could add a link to the internal doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this referring to specifically? Should this whole "assets" section be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.

…nto dit13711/10889-remove-references-to-stencil
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Franco covered most of it but I added some additional comments.

examples/components/webpack/README.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/README.md Outdated Show resolved Hide resolved
packages/calcite-components-react/README.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Documentation.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/README.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/README.md Outdated Show resolved Hide resolved
DitwanP and others added 5 commits January 29, 2025 00:42
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
…nto dit13711/10889-remove-references-to-stencil
@DitwanP DitwanP requested review from benelan and jcfranco January 30, 2025 00:08
…nto dit13711/10889-remove-references-to-stencil
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 🚀

CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/calcite-components/conventions/Documentation.md Outdated Show resolved Hide resolved
@@ -303,6 +303,8 @@ my-component/
...
```

<!-- TODO: Get suggestions for what this should be replaced with -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, assets and anything that is covered by https://qawebgis.esri.com/components/lumina/introduction. We could just link to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants