Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table, table-row): Improve programmatic Table Row selection behavior #11237

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

macandcheese
Copy link
Contributor

@macandcheese macandcheese commented Jan 8, 2025

Related Issue: #11142

Summary

Adds a private event that allows us to update the Table's selectedItems and displayed selection UI when Table Rows are programmatically selected or de-selected, without emitting a public event. Adds local demo and test. Also updates an incorrect private function name within the Table component.

@macandcheese macandcheese requested a review from benelan January 8, 2025 22:57
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 8, 2025
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 8, 2025
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓
🏓💥🏓🏓🏓💥🏓🏓💥💥🏓🏓💥💥💥🏓🏓💥💥💥🏓💥💥💥💥🏓💥🏓
🏓💥💥🏓🏓💥🏓💥🏓🏓💥🏓🏓💥🏓🏓💥🏓🏓🏓🏓💥🏓🏓🏓🏓💥🏓
🏓💥🏓💥🏓💥🏓💥🏓🏓💥🏓🏓💥🏓🏓💥🏓🏓🏓🏓💥💥💥🏓🏓💥🏓
🏓💥🏓🏓💥💥🏓💥🏓🏓💥🏓🏓💥🏓🏓💥🏓🏓🏓🏓💥🏓🏓🏓🏓🏓🏓
🏓💥🏓🏓🏓💥🏓🏓💥💥🏓🏓💥💥💥🏓🏓💥💥💥🏓💥💥💥💥🏓💥🏓
🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓🏓

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macandcheese macandcheese merged commit 2911675 into dev Jan 9, 2025
9 checks passed
@macandcheese macandcheese deleted the macandcheese/11142-table-row-programmatic-update branch January 9, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants