Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up typescript-strict-plugin to help enable strict mode globally #11177

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 30, 2024

Related Issue: N/A

Summary

Wires up typescript-strict-plugin to incrementally convert files to be strict.

Notable changes

  • Adds @ts-strict-ignore comments to files within scope to allow opting into strict mode incrementally
  • Enables strict mode for packages with no existing strict errors
  • Examples and files not covered by existing tsconfig.json files (e.g., support files executed via tsx) are not included – I'll create a follow-up PR for these

…bally

* enables strict on packages that have no strict errors
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 30, 2024
@jcfranco jcfranco changed the title chore: set up typescript-strict-plugin to help enable strict mode globally chore: set up typescript-strict-plugin to help enable strict mode globally Dec 30, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 30, 2024
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcfranco jcfranco merged commit adefb85 into dev Jan 1, 2025
8 of 9 checks passed
@jcfranco jcfranco deleted the jcfranco/set-up-typescript-strict-plugin branch January 1, 2025 00:13
benelan pushed a commit that referenced this pull request Feb 8, 2025
…lobally (#11177)

**Related Issue:** N/A

## Summary

Wires up
[`typescript-strict-plugin`](https://github.com/allegro/typescript-strict-plugin)
to incrementally convert files to be strict.

### Notable changes

* Adds `@ts-strict-ignore` comments to files within scope to allow
opting into strict mode incrementally
* Enables strict mode for packages with no existing strict errors
* Examples and files not covered by existing `tsconfig.json` files
(e.g., support files executed via `tsx`) are not included – I'll create
a follow-up PR for these
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants