Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox-item): fix icon color css override #10874

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix(combobox-item): fix icon color css override #10874

merged 2 commits into from
Nov 26, 2024

Conversation

aPreciado88
Copy link
Contributor

Related Issue: #7854

Summary

Update to allow --calcite-ui-icon-color to override the component's icon color.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 26, 2024
@aPreciado88 aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 26, 2024
jcfranco
jcfranco approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you update custom-theme.stories.ts to include a simple story to cover this? Additional stories and tokens should come in when we add component tokens to combobox via #7180.

@aPreciado88 aPreciado88 added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 26, 2024
@aPreciado88
Copy link
Contributor Author

@ashetland @SkyeSeitz Could you please take a look at the custom theming updates in chromatic?

@aPreciado88 aPreciado88 merged commit b0d5802 into dev Nov 26, 2024
13 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/7854-calcite-ui-icon-color-css-property-does-not-work branch November 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@aPreciado88 aPreciado88

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@aPreciado88 @jcfranco