Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated ban-props-on-host, enforce-ref-last-prop, require-event-emitter-type rules #10679

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 4, 2024

Related Issue: #10398

Summary

Remove deprecated custom ESLint rules.

BREAKING CHANGE: The following deprecated rules from @esri/eslint-plugin-calcite-components have been removed due to changes introduced in #10310:

  • ban-props-on-host
  • enforce-ref-last-prop
  • require-event-emitter-type

Developers should either remain on the current version or remove these rules from their ESLint configuration to avoid potential issues.

…rop`, `require-event-emitter-type` rules

BREAKING CHANGES: The following deprecated rules from `@esri/eslint-plugin-calcite-components` have been removed due to changes introduced in #10310:

* `ban-props-on-host`
* `enforce-ref-last-prop`
* `require-event-emitter-type`

Developers should either remain on the current version or remove these rules from their ESLint configuration to avoid potential issues.
@jcfranco jcfranco requested review from Elijbet and benelan November 4, 2024 06:26
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 4, 2024
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 4, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Nov 4, 2024

Merging to simplify #10310. LMK if anything needs addressing.

@jcfranco jcfranco merged commit c399c10 into dev Nov 4, 2024
15 of 16 checks passed
@jcfranco jcfranco deleted the jcfranco/drop-deprecated-custom-rules branch November 4, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant