Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(switch): add component tokens #10647

Merged
merged 12 commits into from
Nov 15, 2024
Merged

feat(switch): add component tokens #10647

merged 12 commits into from
Nov 15, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Oct 29, 2024

Related Issue: #7180

Summary

adds new component tokens, e2e tests, demo page examples, and chromatic theme tests.

New CSS variables

--calcite-switch-background-color: Specifies the component's background color.
--calcite-switch-background-color-hover: Specifies the component's background color.
--calcite-switch-border-color: Specifies the component's border color.
--calcite-switch-corner-radius: Specifies the component's corner radius.
--calcite-switch-handle-background-color: Specifies the handle's background color.
--calcite-switch-handle-background-color-hover: Specifies the handle's background color.
--calcite-switch-handle-border-color: Specifies the handle's border color.
--calcite-switch-handle-corner-radius: Specifies the handle's corner radius.
--calcite-switch-handle-shadow: Specifies the handle's shadow.

@driskull driskull requested a review from alisonailea October 29, 2024 23:01
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Oct 29, 2024
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We don't need stateful tokens on this component but other than that this looks good to go.

@driskull driskull marked this pull request as ready for review November 1, 2024 23:29
@driskull driskull changed the base branch from dev to lumina November 6, 2024 17:47
@driskull driskull changed the base branch from lumina to dev November 6, 2024 17:47
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 15, 2024
# Conflicts:
#	packages/calcite-components/src/components/switch/switch.e2e.ts
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 15, 2024
@driskull driskull merged commit 69b2977 into dev Nov 15, 2024
13 checks passed
@driskull driskull deleted the dris0000/switch-tokens-7180 branch November 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants