-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(switch): add component tokens #10647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Issues tied to a new feature or request.
label
Oct 29, 2024
alisonailea
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! We don't need stateful tokens on this component but other than that this looks good to go.
driskull
commented
Nov 1, 2024
driskull
commented
Nov 1, 2024
…-design-system into dris0000/switch-tokens-7180
macandcheese
reviewed
Nov 1, 2024
packages/calcite-components/src/components/block-section/block-section.scss
Outdated
Show resolved
Hide resolved
…-design-system into dris0000/switch-tokens-7180
alisonailea
approved these changes
Nov 6, 2024
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Nov 15, 2024
# Conflicts: # packages/calcite-components/src/components/switch/switch.e2e.ts
driskull
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Nov 15, 2024
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Stale
Issues or pull requests that have not had recent activity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
adds new component tokens, e2e tests, demo page examples, and chromatic theme tests.
New CSS variables
--calcite-switch-background-color: Specifies the component's background color.
--calcite-switch-background-color-hover: Specifies the component's background color.
--calcite-switch-border-color: Specifies the component's border color.
--calcite-switch-corner-radius: Specifies the component's corner radius.
--calcite-switch-handle-background-color: Specifies the handle's background color.
--calcite-switch-handle-background-color-hover: Specifies the handle's background color.
--calcite-switch-handle-border-color: Specifies the handle's border color.
--calcite-switch-handle-corner-radius: Specifies the handle's corner radius.
--calcite-switch-handle-shadow: Specifies the handle's shadow.