Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(chromatic): build storybook even when skipping snapshots #10589

Merged
merged 4 commits into from
Oct 24, 2024
Merged

ci(chromatic): build storybook even when skipping snapshots #10589

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c59823
ci(chormatic): build storybook even when skipping snapshots
benelan Oct 23, 2024
a723cde
chore: cleanup
benelan Oct 23, 2024
167fa1f
chore: set environment variables
benelan Oct 23, 2024
89c13bd
Merge branch 'dev' into benelan/always-build-storybook
benelan Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ on:
types: [opened, labeled, synchronize]
jobs:
run:
if: |
(github.event.action == 'labeled' && github.event.label.name == 'pr ready for visual snapshots') || github.event_name == 'push'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -17,18 +15,26 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version-file: package.json
- run: |
- name: Build storybook
env:
STORYBOOK_SCREENSHOT_TEST_BUILD: true
CHROMATIC_DIFF_THRESHOLD: ${{ secrets.CHROMATIC_DIFF_THRESHOLD }}
run: |
npm install
npm --workspace="packages/calcite-design-tokens" run build
npm --workspace="packages/calcite-ui-icons" run build
npm --workspace="packages/calcite-components" run build-storybook
- name: Publish to Chromatic
if: |
(github.event.action == 'labeled' && github.event.label.name == 'pr ready for visual snapshots') || github.event_name == 'push'
uses: chromaui/action@v11
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
zip: true
exitOnceUploaded: true
autoAcceptChanges: ${{ github.base_ref || github.ref_name }}
workingDir: packages/calcite-components
storybookBuildDir: docs
env:
STORYBOOK_SCREENSHOT_TEST_BUILD: true
CHROMATIC_DIFF_THRESHOLD: ${{ secrets.CHROMATIC_DIFF_THRESHOLD }}
Expand Down
Loading