Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prevent mixed Sass mixed declaration warnings #10426

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Sep 27, 2024

Related Issue: #10347

Summary

Updates styles to avoid mixed declaration warnings that will show up after #10310.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Sep 27, 2024
@jcfranco jcfranco requested a review from driskull September 27, 2024 21:32
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Sep 27, 2024
@jcfranco jcfranco merged commit 4d0aac5 into dev Sep 27, 2024
13 checks passed
@jcfranco jcfranco deleted the jcfranco/10347-tidy-up-nested-rule-declarations branch September 27, 2024 22:52
benelan added a commit that referenced this pull request Sep 30, 2024
…estone-estimates

* origin/dev: (26 commits)
  test: fix `window.getComputedStyle` arguments (#10424)
  test(card): remove redundant spy and setup wrapper element (#10429)
  test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431)
  refactor(themed): drop broken, unused, regexp arg support (#10425)
  docs: component token description consistency (#10430)
  refactor: prevent mixed Sass mixed declaration warnings (#10426)
  deprecate: deprecate `enforce-ref-last-prop` rule (#10421)
  chore(actions): add custom `deprecate` type to semantic-pr check (#10427)
  chore(issue templates): add arcgis data pipelines to team dropdown (#10418)
  fix(tooltip): closed tooltips should not reappear (#10420)
  feat: add dashboard-graph (#10417)
  fix(input-time-zone): fix region mode quirks after update (#10413)
  fix(text-area): ensure border-color token doesn't override invalid styles (#10390)
  ci(changelog): add deprecation commits to changelog automation (#10346)
  fix: properly set aria attributes on components (#10404)
  feat: add parcel parameter (#10384)
  feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388)
  feat(dialog, panel): Add css properties for background-color (#10387)
  fix: remove aria-disabled from components where necessary (#10374)
  feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants