Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary page size workaround for disabled test helper #10232

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Sep 6, 2024

Related Issue: N/A

Summary

Removes workaround invalidated by #10219.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Sep 6, 2024
@jcfranco
Copy link
Member Author

Tests are failing, so it seems that setting the window size with browserArgs doesn't have the same effect as page.setViewport.

@jcfranco jcfranco closed this Sep 11, 2024
@jcfranco jcfranco deleted the jcfranco/drop-unnecessary-page-size-workaround-for-disabled-test-helper branch September 11, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant