Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: deprecate widthScale/heightScale in favor of width/height #10202

Closed
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c533b38
refactor: consolidate width and widthScale into one width prop
Elijbet Sep 1, 2024
448af21
provide new property in the css, extract auto and full from interface
Elijbet Sep 1, 2024
72f1008
deprecate heightScale, define new height prop in the interface
Elijbet Sep 1, 2024
434ac8d
half to be deprecated
Elijbet Sep 4, 2024
d3fe676
remove unnecessary values from Height interface
Elijbet Sep 4, 2024
197f852
Doc for deprecated value
Elijbet Sep 4, 2024
e0bcfc9
cleanup accidental add
Elijbet Sep 7, 2024
bfa503a
remove default value
Elijbet Sep 8, 2024
880bb92
remove default from dropdown
Elijbet Sep 8, 2024
435ce0d
WIP
Elijbet Sep 8, 2024
4b33315
dialog width takes precedence over widthScale if both are defined
Elijbet Sep 20, 2024
0e83ac0
typo
Elijbet Sep 20, 2024
23848e3
simplify selectors'
Elijbet Sep 20, 2024
8515421
WIP and add test for deprecated widthScale
Elijbet Sep 20, 2024
ceec250
WIP and dropdown tests, width priority of width-scale
Elijbet Sep 21, 2024
fe85cbe
cleanup and modal tests
Elijbet Sep 21, 2024
2e78022
sheet scss and test
Elijbet Sep 21, 2024
371babb
shell-panel prop precedence and tests
Elijbet Sep 21, 2024
7296c37
modify test to get the className
Elijbet Sep 21, 2024
d9e5146
extract dynamicCSSConst util
Elijbet Sep 25, 2024
472d15e
typo
Elijbet Sep 25, 2024
e43eafd
merge conflicts
Elijbet Oct 8, 2024
c82417f
apply container and height to shell-center-row
Elijbet Oct 8, 2024
0c83c5b
detached height
Elijbet Oct 8, 2024
697cb89
cleanup
Elijbet Oct 8, 2024
7f22fda
adjust tests to account for added container div instead of fragment
Elijbet Oct 9, 2024
49440fc
merge conflicts
Elijbet Oct 9, 2024
f7016a7
adjust test to the new changes
Elijbet Oct 11, 2024
64522f2
remove deprecation e2e test, adjust expected pixel values for style w…
Elijbet Oct 11, 2024
938e2d7
remove deprecation tests
Elijbet Oct 11, 2024
04f4c4a
remove deprecation tests
Elijbet Oct 11, 2024
1da70bf
merge dev
Elijbet Oct 31, 2024
b8efa8b
cleanup
Elijbet Oct 31, 2024
4321c43
consolidate dynamicClasses const getHeight and getWidth inot getDimen…
Elijbet Oct 31, 2024
347c4ed
add spec test for dynamicClasses to systematically check all valid pe…
Elijbet Oct 31, 2024
8f6209a
use describe block instead of it, to keep it blocks on the same level…
Elijbet Oct 31, 2024
7441e50
typo
Elijbet Oct 31, 2024
7cfdb9d
template literal types
Elijbet Oct 31, 2024
919acb2
use existing interface types
Elijbet Oct 31, 2024
9bf32d5
refactor
Elijbet Nov 1, 2024
36d302c
imports
Elijbet Nov 1, 2024
a6be544
imports
Elijbet Nov 1, 2024
619e739
merge dev
Elijbet Nov 1, 2024
a0899f7
remove new defaults to revert screenshot diffs
Elijbet Nov 8, 2024
e578ab8
remove default value in e2e for dropdown
Elijbet Nov 8, 2024
9fa539d
revert test adjustment
Elijbet Nov 8, 2024
5f2ddba
use vh vs % on container, cleanup
Elijbet Nov 12, 2024
61b3395
tidy up
Elijbet Nov 12, 2024
fba447f
return a valid key from util
Elijbet Nov 13, 2024
754f24d
merge dev
Elijbet Nov 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo
  • Loading branch information
Elijbet committed Sep 25, 2024

Verified

This commit was signed with the committer’s verified signature.
sanjayankur31 Ankur Sinha
commit 472d15e7bc762a4ef3c878c3ae58b0456a6a15e5
2 changes: 1 addition & 1 deletion packages/calcite-components/src/utils/dynamicCSSConst.ts
Original file line number Diff line number Diff line change
@@ -3,5 +3,5 @@ export const getWidth = (width: string, widthScale: string): string => {
};

export const getHeight = (height: string, heightScale: string): string => {
return height ? `height-${height}` : heightScale ? `width-${heightScale}` : "";
return height ? `height-${height}` : heightScale ? `height-${heightScale}` : "";
};
Loading