Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rating and Slider] Add form support via required and validationMessage for error handling #9999

Closed
2 of 6 tasks
geospatialem opened this issue Aug 8, 2024 · 2 comments
Closed
2 of 6 tasks

[Rating and Slider] Add form support via required and validationMessage for error handling #9999

geospatialem opened this issue Aug 8, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-10-29 - Oct ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 8, 2024 •
edited by SkyeSeitz
Loading

Check existing issues

Actual Behavior

The rating and slider components do not support form validation, as indicated in #8057.

Expected Behavior

Form validation support. Since invalid styling is not effective on slider and rating, the validationMessage prop would serve as the only visual invalid affordance when a value is not added and required is present.

Reproduction Sample

https://codepen.io/geospatialem/pen/ZEdJaLr

Reproduction Steps

  1. Open the sample
  2. Observe neither component have support for required or validationMessage properties/attributes

Reproduction Version

2.11.1

Relevant Info

Follow-up to #8057 and #8000

Link to Figma specs: https://www.figma.com/design/5QDPzXr21qQcPTkXR1Ouga/Form-Validation-%5BEpic-4598%5D?node-id=956-94284&m=dev&focus-id=1194-2726

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

Medium-High for consistency across the design system with regards to error handling

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels Aug 8, 2024
@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 8, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 8, 2024
@geospatialem geospatialem mentioned this issue Aug 8, 2024
Closed
21 tasks
@aPreciado88 aPreciado88 self-assigned this Oct 11, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 11, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 21, 2024
@aPreciado88 aPreciado88 mentioned this issue Oct 25, 2024
Merged
aPreciado88 added a commit that referenced this issue Oct 29, 2024
@aPreciado88
feat(rating, slider): add validation message to support form error ha…

Verified

This commit was signed with the committer’s verified signature.
drashna Drashna Jaelre
GPG key ID: DBA1FD3A860D1B11
Verified
Learn about vigilant mode
Loading
Loading status checks…
c4c9b1d 
…ndling (#10621)

**Related Issue:**
[#9999](#9999)

## Summary

Add `validationMessage`, `validationIcon` and `status` props to `rating`
and `slider` components to support form validation.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 29, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Oct 29, 2024

🍡 Verified on 2.14.0-next.19

https://codepen.io/Ditwan-Price/pen/BaXrBoO

@DitwanP DitwanP closed this as completed Oct 29, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 29, 2024
benelan pushed a commit that referenced this issue Feb 8, 2025
@aPreciado88 @benelan
feat(rating, slider): add validation message to support form error ha…

Verified

This commit was signed with the committer’s verified signature.
drashna Drashna Jaelre
GPG key ID: DBA1FD3A860D1B11
Verified
Learn about vigilant mode
b632449 
…ndling (#10621)

**Related Issue:**
[#9999](#9999)

## Summary

Add `validationMessage`, `validationIcon` and `status` props to `rating`
and `slider` components to support form validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88