Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel & Flow Item] add footer slot gaps settings #9858

Closed
1 of 6 tasks
SkyeSeitz opened this issue Jul 25, 2024 · 2 comments
Closed
1 of 6 tasks

[Panel & Flow Item] add footer slot gaps settings #9858

SkyeSeitz opened this issue Jul 25, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@SkyeSeitz
Copy link

SkyeSeitz commented Jul 25, 2024 •
edited
Loading

Check existing issues

Description

Add footer-end & footer-start slots according to scale

Acceptance Criteria

Provide horizontal gap setting within footer-start & footer-end slots according to scale
small Panel: space.sm (8px) gap
medium Panel: space.md (12px) gap
large Panel: space.lg (16px) gap


image image

Relevant Info

Link to Figma specs: https://www.figma.com/design/wVqftT1aZDjwYVkDZ2V5fC/Dialog?node-id=1-2&m=dev&focus-id=621-5496

Which Component

Panel & Flow Item

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@SkyeSeitz SkyeSeitz added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jul 25, 2024
@SkyeSeitz SkyeSeitz changed the title [Panel & Flow Item] add footer slot gaps settings [Panel & Flow Item] add footer slot gaps settings & correct heading text styles Jul 26, 2024
@ashetland ashetland changed the title [Panel & Flow Item] add footer slot gaps settings & correct heading text styles [Panel & Flow Item] add footer slot gaps settings Jul 26, 2024
driskull added a commit that referenced this issue Jul 26, 2024
@driskull
fix(panel): add footer slot gaps settings #9858
e0a87bf
@driskull driskull mentioned this issue Jul 26, 2024
Merged
@driskull driskull assigned driskull and unassigned driskull Jul 26, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 29, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jul 29, 2024
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 29, 2024
driskull added a commit that referenced this issue Jul 29, 2024
@driskull
fix(panel): correct footer padding and layout (#9868)
b25a0ae 
**Related Issue:** #9858 #9857

## Summary

- fixes footer-end slot alignment when its the only thing slotted
- refactor styles
- makes footer slot take precedence over the other footer slots
(including deprecated footer-actions)
- add screenshot tests
- cleanup screenshot tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jul 29, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 29, 2024

🍡 Verified locally on dev

Scales:
"s" - gap: 8px
image

"m" - gap: 12px
image

"l" - gap: 16px
image

@DitwanP DitwanP closed this as completed Jul 29, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jul 29, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Jul 29, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@driskull @github-actions
fix(panel): correct footer padding and layout (#9868)
1e02ece 
**Related Issue:** #9858 #9857

## Summary

- fixes footer-end slot alignment when its the only thing slotted
- refactor styles
- makes footer slot take precedence over the other footer slots
(including deprecated footer-actions)
- add screenshot tests
- cleanup screenshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @SkyeSeitz @DitwanP