Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlowItem: footer slots are conflicting with each other #9855

Closed
2 of 6 tasks
driskull opened this issue Jul 25, 2024 · 2 comments
Closed
2 of 6 tasks

FlowItem: footer slots are conflicting with each other #9855

driskull opened this issue Jul 25, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-07-31 - Jul ...

Comments

@driskull
Copy link
Member

driskull commented Jul 25, 2024 •
edited
Loading

Check existing issues

Actual Behavior

When using a flow-item and slotting a footer-start or footer-end it just uses the footer slot internally.

Expected Behavior

It should honor footer-start and footer-end

Reproduction Sample

https://codepen.io/driskull/pen/wvLzNMP?editors=1000

Reproduction Steps

  1. Open the codepen
  2. notice footer slots aren't working properly
  3. footer-start should be on the left and footer-end should be on the right

Reproduction Version

2.10

Relevant Info

No response

Regression?

No

Priority impact

impact - p1 - need for current milestone

Impact

Regression from #8981

#9374

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 25, 2024
driskull added a commit that referenced this issue Jul 25, 2024
@driskull
fix(panel, flow-item): prevent footer slots from conflicting with eac…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
499bc3d 
…h other. #9855
@driskull driskull mentioned this issue Jul 25, 2024
Merged
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
driskull added a commit that referenced this issue Jul 25, 2024
@driskull
fix(panel, flow-item): prevent footer slots from conflicting with eac…
f3a26b6 
…h other (#9856)

**Related Issue:** #9855

## Summary

- prevent footer slots from conflicting
- modify stories
- add doc
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jul 25, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 26, 2024

🍡 Verified on 2.11.0-next.24
image

@DitwanP DitwanP closed this as completed Jul 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 26, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@driskull @github-actions
fix(panel, flow-item): prevent footer slots from conflicting with eac…
cffaff8 
…h other (#9856)

**Related Issue:** #9855

## Summary

- prevent footer slots from conflicting
- modify stories
- add doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP