-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calciteConfig message when same or different versions #9721
Comments
@odoe I can't reproduce the same-version warning with the vite example. Do you have any suggestions on how to get the warning? |
@jcfranco I made a repro here It updates the import './style.css';
// loads calcite from components folder
import { defineCustomElements as defineCalciteElements } from "@esri/calcite-components/dist/loader";
// loads calcite from esm folder
import "@arcgis/map-components/dist/components/arcgis-map";
defineCalciteElements(window, {
resourcesUrl: "https://js.arcgis.com/calcite-components/2.10.1/assets",
});
const loader = document.createElement('calcite-loader');
document.body.appendChild(loader); |
**Related Issue:** #9721 ## Summary This updates the message displayed when components load to show the version, build date and revision (similar to Maps SDK). It will log an info message instead of a warning as it could be misinterpreted and would also show up multiple times when a bundled `calcite-components` version would be overridden. **Note**: `console.info` messages will be omitted by default across all tests to avoid noise
@odoe @COV-GIS Thanks for your help on this one! ✨💪✨ We changed the approach to instead display an info message showing the stamped version to avoid confusion when the same or mismatched versions are encountered. The PR description adds a bit more detail if you're curious. |
Installed and assigned for verification. |
🍡 Verified on |
**Related Issue:** #9721 ## Summary This updates the message displayed when components load to show the version, build date and revision (similar to Maps SDK). It will log an info message instead of a warning as it could be misinterpreted and would also show up multiple times when a bundled `calcite-components` version would be overridden. **Note**: `console.info` messages will be omitted by default across all tests to avoid noise
Check existing issues
Description
Currently, when the
globalThis.calciteConfig
is checked if a Calcite version is loaded, it emits a message that doesn't distinguish if the same version or a different version was loaded.There are cases when the same version could be loaded if an app that uses Stencil built components mixes
import
of components anddefineCustomElements
, which is probably not best practice.Not sure what the message when the same version is loaded should be, but definitely a distinct warning when a different version is loaded, probably means something went wrong.
Acceptance Criteria
Relevant Info
No response
Which Component
calcite-components/src/utils/config.ts
Example Use Case
No response
Priority impact
impact - p3 - not time sensitive
Calcite package
Esri team
ArcGIS Maps SDK for JavaScript
The text was updated successfully, but these errors were encountered: