Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile] slots are start aligned on center alignment component #9540

Closed
1 of 6 tasks
SkyeSeitz opened this issue Jun 7, 2024 · 6 comments
Closed
1 of 6 tasks

[Tile] slots are start aligned on center alignment component #9540

SkyeSeitz opened this issue Jun 7, 2024 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@SkyeSeitz
Copy link

Check existing issues

Actual Behavior

When Tile's alignment prop = "center", slotted content aligns to the start in Tile's content-top & content-bottom slots.

image

Expected Behavior

When Tile's alignment prop = "center", slotted content aligns to the center in Tile's content-top & content-bottom slots.

image

image

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/vYwJGJm?editors=1000

Reproduction Steps

See content-bottom slots with start aligned chips.

Reproduction Version

2.9.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@SkyeSeitz SkyeSeitz added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 7, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 7, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Jun 10, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jun 10, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 10, 2024
@aPreciado88 aPreciado88 self-assigned this Jul 3, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 3, 2024
@aPreciado88 aPreciado88 mentioned this issue Jul 3, 2024
Merged
aPreciado88 added a commit that referenced this issue Jul 12, 2024
@aPreciado88
fix(tile): center align contentTop and contentBottom slots when align…
a462498 
…ment prop equals "center" (#9732)

**Related Issue:**
[#9540](#9540)

## Summary
This updates the `tile` component to center align `content-top` and
`content-bottom` slots when the `alignment` prop is equal to `"center"`
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 12, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 12, 2024 •
edited
Loading

@aPreciado88 Noticing the chips are centered but the text is still not. @SkyeSeitz The text is supposed to be centered as well right?
https://codepen.io/Ditwan-Price/pen/vYqOJQz?editors=1000

@DitwanP DitwanP closed this as completed Jul 12, 2024
@DitwanP DitwanP reopened this Jul 12, 2024
@SkyeSeitz
Copy link
Author

@aPreciado88 Noticing the chips are centered but the text is still not. @SkyeSeitz The text is supposed to be centered as well right? https://codepen.io/Ditwan-Price/pen/vYqOJQz?editors=1000

Correct - text should be centered. Thanks for catching.

@DitwanP DitwanP added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 12, 2024
@DitwanP DitwanP assigned aPreciado88 and unassigned geospatialem Jul 12, 2024
@DitwanP DitwanP removed their assignment Jul 12, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 12, 2024

@aPreciado88 Moved back to address the text not being centered.

@aPreciado88 aPreciado88 mentioned this issue Jul 12, 2024
Merged
aPreciado88 added a commit that referenced this issue Jul 15, 2024
@aPreciado88
fix(tile): center align slot's text when alignment is equal to center (…
4a26398 
…#9773)

**Related Issue:**
[#9540](#9540)

## Summary
updates the `tile` component to center align the slot's text when the
alignment prop is equal to "center"
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 15, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 15, 2024

🍡 Verified on 2.11.0-next.7
https://codepen.io/Ditwan-Price/pen/vYqOJQz

@DitwanP DitwanP closed this as completed Jul 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 23, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@aPreciado88 @github-actions
fix(tile): center align contentTop and contentBottom slots when align…
1a8393b 
…ment prop equals "center" (#9732)

**Related Issue:**
[#9540](#9540)

## Summary
This updates the `tile` component to center align `content-top` and
`content-bottom` slots when the `alignment` prop is equal to `"center"`
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@aPreciado88 @github-actions
fix(tile): center align slot's text when alignment is equal to center (…
8611bfc 
…#9773)

**Related Issue:**
[#9540](#9540)

## Summary
updates the `tile` component to center align the slot's text when the
alignment prop is equal to "center"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@geospatialem @SkyeSeitz @DitwanP @aPreciado88