Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pick List] Remove deprecated component from code base #9296

Closed
1 of 5 tasks
geospatialem opened this issue May 9, 2024 · 2 comments
Closed
1 of 5 tasks

[Pick List] Remove deprecated component from code base #9296

geospatialem opened this issue May 9, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-11-26 - 3.0....

Comments

@geospatialem
Copy link
Member

Description

Remove the pick-list* components from the code base for removal, in favor of the list component.

Proposed Advantages

To use the more a11y and supported list component.

Which Component

  • pick-list
  • pick-list-group
  • pick-list-item

Relevant Info

Will be part of the Calcite 3.0 release in late 2024.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 9, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label May 9, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Jun 28, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 28, 2024
@aPreciado88 aPreciado88 self-assigned this Oct 28, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 28, 2024
@aPreciado88 aPreciado88 mentioned this issue Oct 30, 2024
Merged
aPreciado88 added a commit that referenced this issue Oct 31, 2024
@aPreciado88
refactor(pick-list, pick-list-group, pick-list-item, value-list, valu…
a99368d 
…e-list-group, value-list-item)!: Remove deprecated components. (#10653)

**Related Issues:** 

[#9296](#9296)
[#9297](#9297)

## Summary

Remove the following deprecated components:

- pick-list
- pick-list-group
- pick-list-item
- value-list
- value-list-group
- value-list-item

BREAKING CHANGE: Use the `List` component instead.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 31, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 6, 2024
@geospatialem
Copy link
Member Author

Verified on the dev branch and confirmed the component is inaccessible in 3.0.0-next.7.

benelan pushed a commit that referenced this issue Feb 8, 2025
@aPreciado88 @benelan
refactor(pick-list, pick-list-group, pick-list-item, value-list, valu…
ddfdeeb 
…e-list-group, value-list-item)!: Remove deprecated components. (#10653)

**Related Issues:** 

[#9296](#9296)
[#9297](#9297)

## Summary

Remove the following deprecated components:

- pick-list
- pick-list-group
- pick-list-item
- value-list
- value-list-group
- value-list-item

BREAKING CHANGE: Use the `List` component instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88