Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: [Shell/Shell Center Row] Update slots for consistent refs to Shell Panel #9275

Closed
4 tasks done
geospatialem opened this issue May 7, 2024 · 4 comments
Closed
4 tasks done

Docs: [Shell/Shell Center Row] Update slots for consistent refs to Shell Panel #9275

geospatialem opened this issue May 7, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. docs Issues relating to documentation updates only. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@geospatialem
Copy link
Member

geospatialem commented May 7, 2024 •
edited by DitwanP
Loading

Description

Phase I - targeted May 2024

We need to update the shell slots to ref shell-panel and not shell-center-row , which should be changed for the following slots:

  • panel-bottom
  • panel-top
  • center-row

Phase II - targeted June 2024

Which Component

shell

Resources
@geospatialem geospatialem added docs Issues relating to documentation updates only. 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels May 7, 2024
@geospatialem geospatialem self-assigned this May 7, 2024
@macandcheese
Copy link
Contributor

Implementation note: deprecation of Shell Center Row needs to follow this: #7513

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 20, 2024
@geospatialem geospatialem mentioned this issue May 20, 2024
Merged
geospatialem added a commit that referenced this issue May 20, 2024
@geospatialem
docs(shell): modify panel-named slots to reflect shell-panel (#9372)
a35dfe0 
**Related Issue:**
#9275

## Summary
Updates the `shell` slots to reflect `shell-panel` placement, as we move
towards deprecation of the `shell-center-row`, anticipated for June/July
2024.

Also, includes a minor doc consistency improvement for the `"modals"`,
`"alerts"`, and `"sheets"` slots to reflect `calcite-shell`.
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels May 20, 2024
@DitwanP DitwanP assigned DitwanP and unassigned geospatialem May 29, 2024
@geospatialem
Copy link
Member Author

@DitwanP The dependent issue of #7513 is anticipated to land, but we can move this into August to ensure the doc update. More context in the change provided here: #7513 (comment)

@DitwanP DitwanP added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 15, 2024

🍭Verified on doc site

@DitwanP DitwanP closed this as completed Aug 15, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 15, 2024
@github-actions github-actions bot mentioned this issue Aug 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. docs Issues relating to documentation updates only. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP