Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "readonly" prop/style to Combobox (match style of other "readonly" components). #8666

Closed
2 of 6 tasks
JonUihlein opened this issue Jan 29, 2024 · 2 comments
Closed
2 of 6 tasks

Add "readonly" prop/style to Combobox (match style of other "readonly" components). #8666

JonUihlein opened this issue Jan 29, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-04-30 - Apr ...

Comments

@JonUihlein
Copy link

Check existing issues

Description

Requesting a readOnly equivalent for Combobox, to match the styles of other readOnly inputs. We avoid using disabled to allow selection of text within the input. The styling of readOnly is different compared to disabled and makes the form look strange.

Acceptance Criteria

A property to allow matching the styling of other readOnly inputs.

Relevant Info

No response

Which Component

Combobox

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@JonUihlein JonUihlein added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 29, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Jan 29, 2024
@jcfranco jcfranco mentioned this issue Apr 30, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 30, 2024
@geospatialem geospatialem added this to the 2024-04-30 - Apr Release milestone Apr 30, 2024
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Apr 30, 2024
jcfranco added a commit that referenced this issue Apr 30, 2024
@jcfranco
fix(combobox, input-time-zone): improve readOnly behavior and styling (…
606d80f 
…#9222)

**Related Issue:** #7853 #8666

## Summary

Improves read-only behavior in combobox and applies proper styling.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 30, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Apr 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Apr 30, 2024

🍯 Verified on main

@DitwanP DitwanP closed this as completed Apr 30, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
4 participants
@jcfranco @JonUihlein @geospatialem @DitwanP