Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle: Add public property for selecting a handle and a public event for when selection changes #8522

Closed
2 of 6 tasks
driskull opened this issue Dec 29, 2023 · 2 comments
Closed
2 of 6 tasks

handle: Add public property for selecting a handle and a public event for when selection changes #8522

driskull opened this issue Dec 29, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-01-17 - Jan ...

Comments

@driskull
Copy link
Member

Check existing issues

Description

Handle should have a public property for setting whether or not its selected as well as an event that fires when a handle is clicked/toggled.

Acceptance Criteria

Add public property for selecting a handle and a public event for when selection changes

Relevant Info

No response

Which Component

handle

Example Use Case

<calcite-handle selected onCalciteHandlechange={...} />

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 29, 2023
@driskull driskull mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Dec 29, 2023
@driskull driskull self-assigned this Dec 29, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 29, 2023
@geospatialem geospatialem added the p - medium Issue is non core or affecting less that 60% of people using the library label Jan 2, 2024
driskull added a commit that referenced this issue Jan 2, 2024
@driskull
feat(handle): add selected property and calciteHandleChange event. (#…
d2e9880 
…8484)

**Related Issue:** #8522

## Summary

- depends on #8483
- Renames `activated` property to `selected` to align with other
components
- Makes `selected` public
- Adds public event `calciteHandleChange` for when `selected` is changed
via user
- Renames internal event `calciteInternalHandleChange` to
`calciteInternalAssistiveTextChange` to better illustrate its purpose
- adds tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 2, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Installed and assigned for verification.

benelan pushed a commit that referenced this issue Jan 2, 2024
@driskull @benelan
feat(handle): add selected property and calciteHandleChange event. (#…
e99bbf7 
…8484)

**Related Issue:** #8522

## Summary

- depends on #8483
- Renames `activated` property to `selected` to align with other
components
- Makes `selected` public
- Adds public event `calciteHandleChange` for when `selected` is changed
via user
- Renames internal event `calciteInternalHandleChange` to
`calciteInternalAssistiveTextChange` to better illustrate its purpose
- adds tests
@DitwanP
Copy link
Contributor

DitwanP commented Jan 8, 2024

🍭 Verified locally on main

@DitwanP DitwanP closed this as completed Jan 8, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP