Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: drag handle cell should be accessible via arrow keys #8366

Closed
2 of 6 tasks
driskull opened this issue Dec 7, 2023 · 2 comments
Closed
2 of 6 tasks

List: drag handle cell should be accessible via arrow keys #8366

driskull opened this issue Dec 7, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2023 December Pri...

Comments

@driskull
Copy link
Member

driskull commented Dec 7, 2023

Check existing issues

Actual Behavior

The drag handle can only be accessed using the tab key

Expected Behavior

The drag handle can be accessed using ArrowRight key.

Reproduction Sample

https://codepen.io/driskull/pen/ExrrdYW?editors=1000

Reproduction Steps

  1. Open sample
  2. tab or focus to the list
  3. Use right arrow to navigate within the list
  4. Notice how the drag handle is not accessible that way.

Reproduction Version

2.0.0

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
@driskull driskull mentioned this issue Dec 7, 2023
Merged
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Dec 7, 2023
@driskull driskull self-assigned this Dec 7, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
@driskull driskull added this to the 2023 December Priorities milestone Dec 7, 2023
driskull added a commit that referenced this issue Dec 8, 2023
@driskull
fix(list-item): drag grid cell should be accessible via arrow keys. (#…
2718ab3 
…8353)

**Related Issue:** #8366

## Summary

- Set the drag handle `td` as a grid cell that can be navigated to
- add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 8, 2023

🍭 Verified locally on main

@DitwanP DitwanP closed this as completed Dec 8, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP