Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action-menu: filter hidden and disabled actions from keyboard navigation #8337

Closed
2 of 6 tasks
driskull opened this issue Dec 5, 2023 · 2 comments
Closed
2 of 6 tasks

action-menu: filter hidden and disabled actions from keyboard navigation #8337

driskull opened this issue Dec 5, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2023 December Pri...

Comments

@driskull
Copy link
Member

driskull commented Dec 5, 2023

Check existing issues

Actual Behavior

disabled and hidden items are not filtered from keyboard navigation

Expected Behavior

disabled and hidden items are filtered from keyboard navigation

Reproduction Sample

https://codepen.io/driskull/pen/eYxbMJP?editors=1000

Reproduction Steps

  1. tab to action menu
  2. Use arrow down key
  3. Keep using arrow down key
  4. The disabled or hidden items should not be focusable

Reproduction Version

1.10

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 5, 2023
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Dec 5, 2023
@driskull driskull mentioned this issue Dec 5, 2023
Merged
@driskull driskull self-assigned this Dec 5, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library labels Dec 5, 2023
driskull added a commit that referenced this issue Dec 5, 2023
@driskull
fix(action-menu): Filter hidden or disabled actions via keyboard. (#8336
11c0007 
)

**Related Issue:** #8337

## Summary

- Filter out hidden and disabled actions from keyboard navigation
- Add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 5, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 5, 2023

verified locally on main 🍬

@DitwanP DitwanP closed this as completed Dec 5, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 5, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP