Align tokens with Figma variables #8310
Assignees
Labels
4 - verified
Issues that have been released and confirmed resolved.
breaking change
Issues and pull requests with code changes that are not backwards compatible.
Calcite (dev)
Issues logged by Calcite developers.
calcite-design-tokens
Issues specific to the @esri/calcite-design-tokens package.
enhancement
Issues tied to a new feature or request.
estimate - 2
Small fix or update, may require updates to tests.
impact - p1 - need for current milestone
User set priority impact status of p1 - need for current milestone
p - high
Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
Comments
alisonailea
added a commit
that referenced
this issue
Dec 1, 2023
**Related Issue:** #8310 ## Summary There were some misalignments between figma variables and tokens as well as some changes to names to better align with the naming schema. Core tokens are a logical scale Semantic tokens have meaningful names representing their usage. BREAKING CHANGE: - Box-shadow is now shadow - Core font family tokens use the font name - Remove unnecessary core tokens line-height, font-size, letter-spacing, paragraph-spacing as these can be exclusive to semantic and reference core size tokens - Core size tokens now use their pixel size in their name - Border-radius is now corner-radius - Border-width removed unnecessary tokens none, sm, md, lg - Success, info, warning, and danger colors are now prefixed with the name "status" - --color-status-info-hover
benelan
pushed a commit
that referenced
this issue
Dec 1, 2023
**Related Issue:** #8310 ## Summary There were some misalignments between figma variables and tokens as well as some changes to names to better align with the naming schema. Core tokens are a logical scale Semantic tokens have meaningful names representing their usage. BREAKING CHANGE: - Box-shadow is now shadow - Core font family tokens use the font name - Remove unnecessary core tokens line-height, font-size, letter-spacing, paragraph-spacing as these can be exclusive to semantic and reference core size tokens - Core size tokens now use their pixel size in their name - Border-radius is now corner-radius - Border-width removed unnecessary tokens none, sm, md, lg - Success, info, warning, and danger colors are now prefixed with the name "status" - --color-status-info-hover
benelan
pushed a commit
that referenced
this issue
Dec 1, 2023
**Related Issue:** #8310 ## Summary There were some misalignments between figma variables and tokens as well as some changes to names to better align with the naming schema. Core tokens are a logical scale Semantic tokens have meaningful names representing their usage. BREAKING CHANGE: - Box-shadow is now shadow - Core font family tokens use the font name - Remove unnecessary core tokens line-height, font-size, letter-spacing, paragraph-spacing as these can be exclusive to semantic and reference core size tokens - Core size tokens now use their pixel size in their name - Border-radius is now corner-radius - Border-width removed unnecessary tokens none, sm, md, lg - Success, info, warning, and danger colors are now prefixed with the name "status" - --color-status-info-hover
benelan
pushed a commit
that referenced
this issue
Dec 2, 2023
**Related Issue:** #8310 ## Summary There were some misalignments between figma variables and tokens as well as some changes to names to better align with the naming schema. Core tokens are a logical scale Semantic tokens have meaningful names representing their usage. BREAKING CHANGE: - Box-shadow is now shadow - Core font family tokens use the font name - Remove unnecessary core tokens line-height, font-size, letter-spacing, paragraph-spacing as these can be exclusive to semantic and reference core size tokens - Core size tokens now use their pixel size in their name - Border-radius is now corner-radius - Border-width removed unnecessary tokens none, sm, md, lg - Success, info, warning, and danger colors are now prefixed with the name "status" - --color-status-info-hover
|
@alisonailea I went ahead and marked this one as installed for v2. |
|
Installed and assigned for verification. |
|
Verified in calcite-design-tokens in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check existing issues
Description
Found some misalignments between Figma variables and tokens.
Acceptance Criteria
Calcite Token names and values should align with the Calcite Figma variables
Relevant Info
No response
Which Component
Core and Semantic tokens
Example Use Case
No response
Priority impact
p1 - need for current milestone
Calcite package
Esri team
Calcite (dev)
The text was updated successfully, but these errors were encountered: