Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Conventions] Custom vs native events #82

Closed
jcfranco opened this issue Jul 31, 2019 · 3 comments
Closed

[Conventions] Custom vs native events #82

jcfranco opened this issue Jul 31, 2019 · 3 comments
Assignees
@patrickarlt @paulcpederson
Labels
convention Issues relating to conventions and best practices. enhancement Issues tied to a new feature or request.

Comments

@jcfranco
Copy link
Member

It'd be useful to enhance the event namespacing section with info on when to add a custom event vs relying on native browser ones.
@jcfranco jcfranco added the enhancement Issues tied to a new feature or request. label Jul 31, 2019
@jcfranco jcfranco added this to the 1.0.0 milestone Jul 31, 2019
@macandcheese macandcheese removed this from the 1.0.0 milestone Sep 16, 2019
@julio8a
Copy link

julio8a commented Jan 13, 2020

What's the status of this issue? can we close or does it still need work?

@jcfranco
Copy link
Member Author

I think we still need to add a note about leveraging existing DOM events whenever possible and to create custom ones when we need a specialized event.

@paulcpederson paulcpederson added the convention Issues relating to conventions and best practices. label May 8, 2020
@paulcpederson paulcpederson self-assigned this May 18, 2020
paulcpederson added a commit that referenced this issue Jul 2, 2020
@paulcpederson
📜 Add note about using existing DOM events to conventions doc (#82)
806aef3
@paulcpederson paulcpederson mentioned this issue Jul 2, 2020
Merged
@paulcpederson
Copy link
Member

Added note to conventions doc

alisonailea pushed a commit that referenced this issue Aug 29, 2023
@manuelalcosta
Merge pull request #82 from Esri/designer/manuelacosta
e71f9aa 
Designer/manuelacosta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickarlt patrickarlt

@paulcpederson paulcpederson

Labels
convention Issues relating to conventions and best practices. enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jcfranco @patrickarlt @paulcpederson @macandcheese @julio8a