Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add automation to low risk milestones as a fail safe #7531

Closed
geospatialem opened this issue Aug 15, 2023 · 6 comments
Closed

CI: Add automation to low risk milestones as a fail safe #7531

geospatialem opened this issue Aug 15, 2023 · 6 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Milestone
1.8.0 Maintenance...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 15, 2023 •
edited
Loading

Summary

Add automation to our CI 🤖⚙️ supporting low risk milestones, where we should have a failsafe and only allow PRs to be merged in after review if any of the following labels are added:

  • low risk
  • p - high
  • p - critical
  • regression

Desired Outcome

Add a failsafe 🔏, so only critical and/or low risk PRs can be merged in during our low risk milestones.

Resources

Examples of low risk milestone naming conventions:
- 1.6.0 - Low risk issues only
- 2023 October Priorities - Low risk only

With our new naming of Maintenance, let's modify the original ask to just Maintenance, similar to:
@geospatialem geospatialem added tooling Issues relating to build system fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 15, 2023
@geospatialem geospatialem added this to the 2023 August Priorities milestone Aug 15, 2023
@geospatialem
Copy link
Member Author

Updated the ask above to fit our new naming convention of "Maintenance" releases, similar to the 1.6.1 Maintenance Release milestone.

@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 21, 2023
@benelan benelan mentioned this issue Aug 21, 2023
Merged
benelan added a commit that referenced this issue Aug 24, 2023
@benelan
ci: add action to limit pull requests during maintenance releases (#7556
e4dd104 
)

**Related Issue:** #7531

## Summary

Add a GH Action that fails (preventing merges) if the current milestone
matches "Maintenance" and the pull request isn't labeled with one of
`["low risk", "p - high", "p - critical", "regression"]`.
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 24, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

Elijbet pushed a commit that referenced this issue Aug 24, 2023
@benelan @Elijbet
ci: add action to limit pull requests during maintenance releases (#7556
ad2270f 
)

**Related Issue:** #7531

## Summary

Add a GH Action that fails (preventing merges) if the current milestone
matches "Maintenance" and the pull request isn't labeled with one of
`["low risk", "p - high", "p - critical", "regression"]`.
@geospatialem
Copy link
Member Author

Performed a test with #7611 via this action.

It seems like if the Maintenance milestone is up next, it continues to the next milestone where it succeeds? To make sure the milestone dates weren't off I modified this test Maintenance milestone to 8/28 and our upcoming August milestone to 8/29. I reset both dates with the upcoming release, so they will look different when viewing this comment later.

@benelan I might be missing a step in the workflow, can you take a peek to confirm?

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 1, 2023
@geospatialem geospatialem removed their assignment Sep 1, 2023
@geospatialem
Copy link
Member Author

@benelan Reassigning to September's milestone for additional R&D. Wasn't able to verify earlier this week.

@benelan benelan mentioned this issue Sep 1, 2023
Merged
benelan added a commit that referenced this issue Sep 1, 2023
@benelan
ci: make sure to exit on maitenance milestone failure (#7656)
6dd8ab3 
**Related Issue:** #7531

## Summary

The action correctly determined that it was a maintenance milestone and
[set the error
message](https://github.com/Esri/calcite-design-system/actions/runs/5988880275/job/16244580547#step:3:39).
However, it looks like
[`core.setFailed()`](https://github.com/actions/toolkit/tree/main/packages/core#exit-codes)
sets the exit code but doesn't actually exit. And then the else block
with `process.exit(0)` overrode the exit code in the next iteration.
Explicitly exiting will fix the issue.
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned benelan Sep 1, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 1, 2023
@geospatialem
Copy link
Member Author

Verified with action 1 with no low risk label and action 2 with a low risk label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. p - high Issue should be addressed in the current milestone, impacts component or core functionality tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
1.8.0 Maintenance Release
Development

No branches or pull requests
2 participants
@geospatialem @benelan